Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo is not uploading from the reaction admin #312

Closed
2 tasks done
hamza0200 opened this issue Aug 12, 2020 · 5 comments
Closed
2 tasks done

Logo is not uploading from the reaction admin #312

hamza0200 opened this issue Aug 12, 2020 · 5 comments
Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm

Comments

@hamza0200
Copy link

We have followed the Reaction Development Platform to install Reaction.

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?

Issue Description

When we are trying to upload logo from the admin shop the logo is not uploading. We have tried to stop/start docker and even tried to reset cache multiple times but it doesnot work at all. It is giving different errors on different browser's console, please open below screenshots for viewing errors:

Steps to Reproduce

  1. Login to reaction admin dashboard
  2. Navigate to Settings > Shop > Shop Logos
  3. Upload logo

Possible Solution

The logo should upload

System information

We are getting this error on multiple systems:

  • MAC OS Catalina
  • Ubuntu 20.04 LTS
@ghost
Copy link

ghost commented Aug 19, 2020

Appears to be related to #282 and #291 and possibly reactioncommerce/example-storefront#720. I noticed in the docs website there's no entry for "Logos" for API version 3.8.0. The last version where "logo" was last mentioned in the docs was 3.7.0. So it seems this feature may not be functional in the most current version of the API or in Beta 7 of the Admin.

It would be helpful if someone who has prior experience with Reaction Commerce could comment on how this feature is supposed to work so user expectations are set properly when this issue is resolved.

Potentially related: reactioncommerce/reaction#5563

Edited for clarity.

@kieckhafer
Copy link
Member

#282 seems to explain that the missing refetchProduct function might be the cause., I'm playing around with it right now, I think just importing the missing functions should solve it. Will create a PR if that's the case.

As for a temporary solution, if you use the URL to link to an existing image, it does work:

Screen Shot 2020-08-20 at 4 46 19 PM

The shop image should work in both instances, either by an existing image uploaded via a URL, or by uploading the image directly. Logo is still in the docs: https://docs.reactioncommerce.com/docs/shop-admin

@hamza0200
Copy link
Author

reactioncommerce/reaction-admin#282 seems to explain that the missing refetchProduct function might be the cause., I'm playing around with it right now, I think just importing the missing functions should solve it. Will create a PR if that's the case.

As for a temporary solution, if you use the URL to link to an existing image, it does work:

Screen Shot 2020-08-20 at 4 46 19 PM

The shop image should work in both instances, either by an existing image uploaded via a URL, or by uploading the image directly. Logo is still in the docs: https://docs.reactioncommerce.com/docs/shop-admin

Thank You @kieckhafer ,

The issue is reported here at reactioncommerce/example-storefront#720 , that when we use static logo URL it becomes visible in reaction-admin but the logo is not visible in the storefront.

It shows text-based store name on storefront.

@kieckhafer
Copy link
Member

Issue 143, referenced in the comment above, has been moved to the example-storefront repository

reactioncommerce/example-storefront#720

@kieckhafer
Copy link
Member

Moving this issue to reaction-admin

@kieckhafer kieckhafer transferred this issue from reactioncommerce/reaction-development-platform Aug 21, 2020
@nnnnat nnnnat added core work For issues that track feature development work being done by core Reaction developers needs triage For issues that are awaiting triage by the core development team labels Jan 19, 2021
@Akarshit Akarshit added bug For issues that describe a defect or regression in the released software verified reproducible For issues that describe bugs that the core team was able to confirm and removed needs triage For issues that are awaiting triage by the core development team labels Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software core work For issues that track feature development work being done by core Reaction developers verified reproducible For issues that describe bugs that the core team was able to confirm
Projects
None yet
Development

No branches or pull requests

5 participants