Defer to discord for disabling at-everyone in webhooks #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discord already has permissions for whether the bot can ping everyone, and the webhook send method has a `disableEveryone` option, so let's defer to the inbuilt Discord permission for this. When permissions can't be found (shouldn't happen), defaults to disabling the pings. Fixes reactiflux#494
This was referenced Aug 1, 2019
1 similar comment
|
This appears to, when a user with a name partially matching here / everyone, for example "eve" exists in the server, will ping "eve" instead of everyone. though, this lax pinging seems to be greater than the scope of this issue. /o/ |
|
That's standard for Discord pings – if you type |
|
I'll merge this for now, since it seems quite important for large bridges – we can amend it later if needs be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, webhooks permit IRC users to send
@everyoneand@herepings through, as they're not stripped (and webhooks always have this permission).Discord already has permissions for whether the bot can ping everyone, and the webhook send method has a
disableEveryoneoption, so let's defer to the inbuilt Discord permission for this.When permissions can't be found (shouldn't happen), defaults to disabling the pings.
Fixes #494. Supersedes #496 and #457.