Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhookDisableEveryone option #457

Closed
wants to merge 1 commit into from

Conversation

tadeokondrak
Copy link

On Discord, webhooks automatically have mass ping permissions that can't be removed. This patch adds a config option to tell discord.js to insert an invisible character in mass pings to prevent this from happening.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.085% when pulling 9c8c176 on tadeokondrak:master into 3087661 on reactiflux:master.

@simvux
Copy link

simvux commented Mar 4, 2019

Any chance of this getting merged?

@Throne3d
Copy link
Collaborator

Throne3d commented Aug 1, 2019

I've implemented this by deferring to the discord permission in #497 – that way, we don't need a global configuration option; users can configure it using the built-in Discord interface and control it with the usual permissions setup in the normal way. Hopefully we can merge that soon!

@Throne3d Throne3d closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants