-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider excluding built files from repo #29
Comments
Yeah, thing is that you don't publish anything to Bower, it just gets the package from Github. We could have separate projects for the source and build? |
That would work actually - a repo each for AMD + CommonJS + another for the source. I'll look into doing that. |
Yeah sounds good having a separate repo for Bower, heres the I wonder if it would be worth looking into using a UMD wrapper for the modules so we don't need the extra duplication of both AMD and CommonJS dirs, we could add this as a build step. React are looking to use pure-cjs for this facebook/react#1002 |
I'm not sure pure-cjs fits the bill. It seems to only wrap the top level module in UMD which wouldn't let you require specific components. I think its fine as it is if we add Probably worth doing it at the same time as moving to an org as you have to write a nice letter to the Bower people to get them to move the package. What was that react component org you mentioned before? |
Right yeah i thought might be the case, would you still include the The react org is: https://github.com/reactjs. |
No, I'd only include the built files for that module system in the root of the repo so no more |
Have published built packages for npm and bower at https://github.com/react-bootstrap Will have to wait for Bower to update their db before removing the built files from here bower/bower#120 |
Nice work! |
Right have got fed up waiting for Bower and removed the built files from here. They are now at https://github.com/react-bootstrap |
…nterpreted-as-a-re bugfix: user input was interpreted as a regular expression
There are quite a few built files for this repo now, and having these committed along with changes makes it quite difficult to follow the changes and review code. If possible it would be nice to
.gitignore
the build directories and just build them before publishing NPM or Bower packages. What are your thoughts on this?The text was updated successfully, but these errors were encountered: