Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider excluding built files from repo #29

Closed
pieterv opened this issue Feb 12, 2014 · 9 comments
Closed

Consider excluding built files from repo #29

pieterv opened this issue Feb 12, 2014 · 9 comments

Comments

@pieterv
Copy link
Contributor

pieterv commented Feb 12, 2014

There are quite a few built files for this repo now, and having these committed along with changes makes it quite difficult to follow the changes and review code. If possible it would be nice to .gitignore the build directories and just build them before publishing NPM or Bower packages. What are your thoughts on this?

@stevoland
Copy link
Contributor

Yeah, thing is that you don't publish anything to Bower, it just gets the package from Github. We could have separate projects for the source and build?

@stevoland
Copy link
Contributor

That would work actually - a repo each for AMD + CommonJS + another for the source. I'll look into doing that.

@pieterv
Copy link
Contributor Author

pieterv commented Feb 13, 2014

Yeah sounds good having a separate repo for Bower, heres the react one for referance: https://github.com/facebook/react-bower

I wonder if it would be worth looking into using a UMD wrapper for the modules so we don't need the extra duplication of both AMD and CommonJS dirs, we could add this as a build step. React are looking to use pure-cjs for this facebook/react#1002

@stevoland
Copy link
Contributor

I'm not sure pure-cjs fits the bill. It seems to only wrap the top level module in UMD which wouldn't let you require specific components. I think its fine as it is if we add react-bootstrap-bower and react-bootstrap-npm repos.

Probably worth doing it at the same time as moving to an org as you have to write a nice letter to the Bower people to get them to move the package. What was that react component org you mentioned before?

@pieterv
Copy link
Contributor Author

pieterv commented Feb 14, 2014

Right yeah i thought might be the case, would you still include the cjs and amd dirs in both packages?

The react org is: https://github.com/reactjs.
Wow the bower people still haven't fixed that, guess that makes sense then.

@stevoland
Copy link
Contributor

No, I'd only include the built files for that module system in the root of the repo so no more amd and cjs dirs

@stevoland
Copy link
Contributor

Have published built packages for npm and bower at https://github.com/react-bootstrap

Will have to wait for Bower to update their db before removing the built files from here bower/bower#120

@pieterv
Copy link
Contributor Author

pieterv commented Mar 5, 2014

Nice work!

@stevoland
Copy link
Contributor

Right have got fed up waiting for Bower and removed the built files from here. They are now at https://github.com/react-bootstrap

aryad14 pushed a commit to aryad14/react-bootstrap that referenced this issue Oct 11, 2023
…nterpreted-as-a-re

bugfix: user input was interpreted as a regular expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants