-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched from browserify to pure-cjs builder #1002
Conversation
* Dropped dependency on emulation of Node.js native modules. * Added deamdify step for JSXTransformer build.
Added some more optimizations + fixes for JSXTransformer build, so providing updated stats:
|
wowzers. Can you send me a link to the |
Sorry, currently not at machine I have React cloned at. You can get general idea of optimization from https://github.com/RReverser/pure-cjs/blob/master/sample/a.out.js. Do you want me to clone and build it on this machine? |
This is great! |
So it looks like the name |
Yep, it doesn't (that's actually the reason I decided to use different name for this function in generated code). |
@petehunt, could you open the link? Any thoughts on this? |
We probably want to change the file names so they don't imply the use of browserify. Maybe something more generic, like |
Yeah, I didn't rename files since it wasn't the most |
Removed uglification for separate files since it significantly slowed down build (browserify:min became 26 sec instead of 110, same for :addonsMin) while gave economy in ~70 bytes for min+gz version.
Switch from browserify to pure-cjs bundler.
Just talked with @benjamn a second too late, but we're going to revert and ship 0.9 with the knowns (browserify) instead of introducing this right now. I want to cut that branch this week so hopefully we'll reland this in master right after that. |
Ok, let me know when you want to merge this again, so we could resolve merge issues if any. |
Ping, 0.9 is now live :) |
Switched to recast-based own pure-cjs CommonJS builder which allows to save ~10% of minified+gzipped library size.
Current comparison table is following (used output of
grunt-compare-size
):