Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect floating window position when contents contains code fences #242

Open
kulakilam opened this issue Nov 30, 2022 · 1 comment
Open

incorrect floating window position when contents contains code fences #242

kulakilam opened this issue Nov 30, 2022 · 1 comment

Comments

@kulakilam
Copy link
Contributor

the floating window's height is 4, the number of lines above is 5, but the floating window still be under current line.
image
there is a gap of two lines height between the current line and the floating window.
image
@kulakilam
Copy link
Contributor Author

I opened a pull request to solve this issue #243

kulakilam added a commit to kulakilam/lsp_signature.nvim that referenced this issue Nov 30, 2022
@kulakilam
Fix incorrect floating window position
7d6014d 
actually last PR(ray-x#243 )didn't solve the issue(ray-x#242 ) because the calculation should be done before make_floating_popup_options()
@kulakilam kulakilam mentioned this issue Nov 30, 2022
Merged
@LostNeophyte LostNeophyte mentioned this issue Dec 6, 2022
Open
ray-x pushed a commit that referenced this issue Oct 9, 2023
@kulakilam
Fix incorrect floating window position (#244)
1eb3bb5 
actually last PR(#243 )didn't solve the issue(#242 ) because the calculation should be done before make_floating_popup_options()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kulakilam