Signature help is too high above cursor

[LostNeophyte]

There are two empty lines between the current line and the window. It only happens in the first half of the screen

minimal config:
https://github.com/ray-x/lsp_signature.nvim/blob/master/tests/init_pack.lua with sumneko_lua instead of tsserver

[ray-x]

Strange, I did not see it in the default config.
Are you using a GUI neovim frontend ?

[LostNeophyte]

Just the terminal, it's weird I think it started after installing noice, but I uninstalled it and it's still happening, even in toolbox(podman)

[ray-x]

did you still have noice turn on in lspsignature setup? It will add empty lines to signature

[LostNeophyte]

I completely uninstalled noice, and it was even happening with the clean config. In a couple hours I'll check it on a different machine where noice was never installed just to be sure

[ray-x]

what is your lua lsp server version and your neovim version?

[LostNeophyte]

It happened in neovim nightly 0.9 and 0.8sumneko: 3.6.3 23 Nov 2022, 07:01 by ***@***.***:

…

what is your lua lsp server version and your neovim version? — Reply to this email directly, > view it on GitHub <#234 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/A2KZQTXZTTBKXPYA6PPFGCTWJWXKTANCNFSM6AAAAAASIFNP74>> . You are receiving this because you authored the thread.> Message ID: > <ray-x/lsp_signature> .> nvim/issues/234/1324588175> @> github> .> com>

[LostNeophyte]

Same thing is happening on the different machine, with sumneko 2.something

[ray-x]

I can see it with default config and latest neovim. Seems the border height calculation is incorrect with that combination.

[ray-x]

I pushed a fix. Seems to work fine for me. Could you check?

[opalmay]

Hi! Thank you for the fix.
The issue is mostly solved, but not for the first time it shows when using toggle_key

[LostNeophyte]

It still happens for me

[LostNeophyte]

doesn't work with require:

but works with print:

[LostNeophyte]

:lua =vim.lsp.util._make_floating_popup_size({ "```lua", "hi", "```", "2nd line" },{} returns 8, 4
so it looks like it counts ``` lines even though they aren't displayed

so if you add the border to the returned height, it's actually too much, I'm not sure if that isn't a bug on nvim's side in that case

[ray-x]

I noticed require has some empty lines in its signature doc. It can be the size calculation is not correct somewhere. In your example, it might be correct if the borders are included.

[LostNeophyte]

this fixes the issue, I hope it helps, I think it also solves #242 and #224, It may not work with signature that doesn't have code blocks though, I don't know which lsp server to use to test that