Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick][KubeRay][Autoscaler] Make KubeRay CRD version configurable #40392

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Oct 17, 2023


Why are these changes needed?

Cherry-pick #40357. Without this PR, KubeRay v1.1.0 will not be able to support this Ray version. See the PR description of #40357 for more details.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421 kevin85421 marked this pull request as ready for review October 17, 2023 04:55
@architkulkarni architkulkarni added release-blocker P0 Issue that blocks the release v2.7.1-pick labels Oct 17, 2023
@GeneDer GeneDer requested a review from zhe-thoughts October 17, 2023 16:16
@GeneDer
Copy link
Contributor

GeneDer commented Oct 17, 2023

This is a functional change. Since we already released 2.7.1, merging this PR will have no affect. It's already in master, will go out with 2.8.0 today

@GeneDer GeneDer closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants