[KubeRay][Autoscaler] Make KubeRay CRD version configurable #40357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
4 tasks
kevin85421
requested review from
wuisawesome,
DmitriGekhtman,
ericl,
architkulkarni and
a team
as code owners
|
cc @rickyyx |
|
cc @gvspraveen |
rickyyx
approved these changes
Oct 16, 2023
|
@rickyyx The current Ray CI covers part of it (the latest KubeRay release). KubeRay CI tests both the nightly KubeRay and the latest KubeRay release. After v1.0.0 is released, I will add a new CI test in KubeRay CI that only uses CRD v1. |
2 tasks
|
Open an issue to track the progress ray-project/kuberay#1499. |
|
Hi @rickyyx, does #40357 (comment) make sense to you? If it makes sense to you, could you please merge this PR? It's blocking the KubeRay release. Thank you! |
kevin85421
added a commit
to kevin85421/ray
that referenced
this pull request
Oct 17, 2023
…ect#40357) --------- Signed-off-by: kaihsun <[email protected]>
8 tasks
|
just noticed a small typo in the description
should be
|
|
@davidxia good catch! Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The KubeRay community has decided to bump the CRD version from v1alpha1 to v1 in the KubeRay v1.0.0-rc.1 release. Initially, I also planned to delete CRD v1alpha1 in v1.0.0-rc.1. However, the Ray Autoscaler has hard-coded the CRD version to v1alpha1. As a result, the Autoscaler will throw an exception when attempting to fetch data from the Kubernetes API server, given that CRD v1alpha1 no longer exists. See ray-project/kuberay#1492 (comment) for more details.
This PR makes the CRD version configurable, and KubeRay v1.0.0-rc.1 will automatically inject the environment variable
KUBERAY_CRD_VER(ray-project/kuberay#1496).KUBERAY_CRD_VERenvironment variable set tov1. If users are on KubeRay v1.0.0, the Autoscaler in Ray 2.8.0 and later versions (including this PR) will use CRD v1. For Ray versions older than 2.8.0, the Autoscaler will use CRD v1alpha1 since those versions don't include this PR.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.KubeRay v0.6.0: CI
KubeRay v1.0.0 (including CRD v1alpha1 and v1): Try to fetch both CRD v1alpha1 and CRD v1 from Kubernetes API server in the Autoscaler sidecar container, and both results are the same.
KubeRay v1.1.0 (only has CRD v1): Try to fetch both CRD v1alpha1 and CRD v1 from Kubernetes API server in the Autoscaler sidecar container. Fail to fetch data when I use CRD v1alpha1.
