[Doc][KubeRay] Doc for Helm chart RBAC #40360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evalaiyc98 <[email protected]>
|
cc @kevin85421 Please take a look. |
Signed-off-by: evalaiyc98 <[email protected]>
Signed-off-by: Kai-Hsun Chen <[email protected]>
Improve RBAC doc
Signed-off-by: evalaiyc98 <[email protected]>
Signed-off-by: evalaiyc98 <[email protected]>
Signed-off-by: evalaiyc98 <[email protected]>
change ClusterRoleBinding/ RoleBinding to ClusterRole/ Role Signed-off-by: evalaiyc98 <[email protected]>
kevin85421
requested review from
architkulkarni,
maxpumperla,
pcmoritz,
kevin85421 and
a team
as code owners
kevin85421
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM. I have already discussed this document offline with @evalaiyc98 several times.
architkulkarni
approved these changes
Oct 26, 2023
Co-authored-by: Archit Kulkarni <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]>
angelinalg
approved these changes
Oct 27, 2023
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Yu-Chen Lai <[email protected]>
|
Thanks for @angelinalg. I have updated the file. |
|
Windows Serve tests unrelated |
architkulkarni
added
the
tests-ok
kevin85421
added a commit
to kevin85421/ray
that referenced
this pull request
Nov 1, 2023
I would like to enhance the user experience for installing Helm chart RBAC in KubeRay. Since there is'n an existing document for this, I integrate these PRs including KubeRay ray-project#1190, ray-project#1162, ray-project#1106, and create a comprehensive document to assist users in quickly and easily setting up RBAC resource. --------- Signed-off-by: evalaiyc98 <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Yu-Chen Lai <[email protected]> Co-authored-by: Kai-Hsun Chen <[email protected]> Co-authored-by: Kai-Hsun Chen <[email protected]> Co-authored-by: Archit Kulkarni <[email protected]> Co-authored-by: angelinalg <[email protected]>
8 tasks
vitsai
pushed a commit
that referenced
this pull request
Nov 2, 2023
I would like to enhance the user experience for installing Helm chart RBAC in KubeRay. Since there is'n an existing document for this, I integrate these PRs including KubeRay #1190, #1162, #1106, and create a comprehensive document to assist users in quickly and easily setting up RBAC resource. --------- Signed-off-by: evalaiyc98 <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Kai-Hsun Chen <[email protected]> Signed-off-by: Yu-Chen Lai <[email protected]> Co-authored-by: Yu-Chen Lai <[email protected]> Co-authored-by: Archit Kulkarni <[email protected]> Co-authored-by: angelinalg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I would like to enhance the user experience for installing Helm chart RBAC in KubeRay. Since there is'n an existing document for this, I integrate these PRs including KubeRay #1190, #1162, #1106, and create a comprehensive document to assist users in quickly and easily setting up RBAC resource.
Related issue number
Checks
I've signed off every commit(by using the -s flag, i.e.,
git commit -s) in this PR.I've run
scripts/format.shto lint the changes in this PR.I've included any doc changes needed for https://docs.ray.io/en/master/.
method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
I have checked the output and made sure the document is working as expected.
Note that, due to doc dependency conflict as this issue [doc][docs infra] update instructions for installing lint dependencies #39962 stated , I will check to ensure the changes align with Ray's style guide.