Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][docs infra] update instructions for installing lint dependencies #39962

Open
angelinalg opened this issue Sep 28, 2023 · 6 comments
Open
Assignees
Labels
docs An issue or change related to documentation P0 Issues that should be fixed in short order

Comments

@angelinalg
Copy link
Contributor

Description

Got dependency conflicts after installing lint requirements, while trying to set up local docs build environment.

Link

https://docs.ray.io/en/master/ray-contribute/docs.html#install-dependencies

@angelinalg angelinalg added P0 Issues that should be fixed in short order docs An issue or change related to documentation labels Sep 28, 2023
@evalaiyc98
Copy link
Contributor

evalaiyc98 commented Oct 13, 2023

I think the problems are interrelated. When I followed the guide, I think there are no dependency conflicts in lint-requirements.txt. The screenshot below displays the result of running pip install -r python/requirements/lint-requirements.txt.

lint-requirements

However, there were indeed dependency conflicts in text-requirements.txt, as illustrated in the screenshot below.
Result of running pip install -c python/requirements.txt -r python/requirements/test-requirements.txt

test-requirements

@evalaiyc98
Copy link
Contributor

@peytondmurray Are you interested in resolving this? If not, I'd be more than happy to contribute.

@peytondmurray
Copy link
Contributor

@evalaiyc98 If you're happy to do it, I'm happy to let you! Thanks so much!

@anyscalesam
Copy link
Contributor

@evalaiyc98 any ETA on that PR?

@evalaiyc98
Copy link
Contributor

I think I will try my best in two weeks, if not achieve the goal, I will close that PR.

@aslonnie
Copy link
Collaborator

aslonnie commented Aug 6, 2024

not sure if this is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation P0 Issues that should be fixed in short order
Projects
None yet
Development

No branches or pull requests

6 participants