[kuberay] More aggressive autoscaling defaults #26985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
4 tasks
sriram-anyscale
approved these changes
Jul 26, 2022
| idle_timeout_minutes = 5.0 | ||
| if autoscaler_options.get(UPSCALING_KEY) == UPSCALING_VALUE_AGGRESSIVE: | ||
| upscaling_speed = 1000 # i.e. big | ||
| idle_timeout_minutes = 1.0 |
There was a problem hiding this comment.
The result from line 111 can end up being 0 due to rounding down.
There was a problem hiding this comment.
I don't think that's true.
From the CRD definition, the field being divided is an integer. Doing / by a float in Python3 does float division.
However, I don't think we currently validate that the integer is positive -- we can do that later in KubeRay.
| upscaling_speed = 1 # Rate-limit upscaling if "Conservative" is set by user. | ||
| # This elif is redudant but included for clarity. | ||
| elif autoscaler_options.get(UPSCALING_KEY) == UPSCALING_VALUE_DEFAULT: | ||
| upscaling_speed = 1000 # i.e. big, no rate-limiting by default |
There was a problem hiding this comment.
I assume people know about this change and its implications?
There was a problem hiding this comment.
People can refer to two groups
Users:
Autoscaling support is new in KubeRay --- it suffices to cover in the docs, which I will do.
Ray developers:
Are aware of the change and its implications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitri Gekhtman [email protected]
Why are these changes needed?
Together with KubeRay PR ray-project/kuberay#414, addresses KubeRay issue ray-project/kuberay#359: gives the autoscaler more aggressive defaults when using KubeRay
(no upscale rate limit, faster idle timeout).
Related issue number
Checks
scripts/format.shto lint the changes in this PR.