Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Set better autoscaling defaults #359

Closed
2 tasks done
DmitriGekhtman opened this issue Jul 8, 2022 · 2 comments · Fixed by #414
Closed
2 tasks done

[Feature] Set better autoscaling defaults #359

DmitriGekhtman opened this issue Jul 8, 2022 · 2 comments · Fixed by #414
Assignees
Labels
autoscaler enhancement New feature or request

Comments

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Jul 8, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

The historical default behavior for the autoscaler is to set the worker idleTimeout to 5 upscalingSpeed to 1 (rate-limit scale-up).

Many (perhaps most) users find this behavior undesirable -- more responsive behavior from the Ray autoscaler is usually preferred.

For upscaling, maxReplicas is enough of an upper cap on autoscaling. Users tend to prefer upscaling as soon as they submit a Ray workload.
For downscaling, users prefer to release resources as soon as they are not needed, particularly since lower-level infrastructure (cluster autoscaler) may keep nodes around even if after the Ray pod is terminated.

The current options exposed by KubeRay are
upscalingMode: Default (rate-limited) and
upscalingMode: Aggressive (no rate limit).

I'd change these to
upscalingMode: Default (no rate limit)
upscalingMode: Conservative (rate limit, translates to upscaling_speed 1).

For compatibility we can keep Aggressive and make it equivalent to Default.

Use case

Responsive autoscaling. More suitable defaults for common use-cases.

Related issues

Follow up to #278

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@DmitriGekhtman DmitriGekhtman added the enhancement New feature or request label Jul 8, 2022
@DmitriGekhtman DmitriGekhtman self-assigned this Jul 8, 2022
@DmitriGekhtman
Copy link
Collaborator Author

Might actually leave this alone for now and instead cover the behavior in the docs.

@DmitriGekhtman
Copy link
Collaborator Author

DmitriGekhtman commented Jul 19, 2022

Actually, might just go ahead and open a PR for this after all.

@DmitriGekhtman DmitriGekhtman added this to the v0.3.0 release milestone Jul 19, 2022
@DmitriGekhtman DmitriGekhtman changed the title [Feature][Minor] Set better autoscaling defaults [Feature] Set better autoscaling defaults Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoscaler enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants