Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Skip test_valid_actor_state tests on windows #19114

Merged
merged 7 commits into from
Oct 6, 2021
Merged

[client] Skip test_valid_actor_state tests on windows #19114

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df45d54
skip test_wrapped_actor_creation on windows
ckw017 Sep 30, 2021
3a3c465
rerun windows ci
ckw017 Sep 30, 2021
3ef892b
Merge branch 'master' of github.com:ray-project/ray into annotateclie…
ckw017 Oct 5, 2021
c7527c8
mark test_valid_actor_state_2 as flaky
ckw017 Oct 5, 2021
5e3f277
mark test_valid_actor_state
ckw017 Oct 5, 2021
c1f8e02
rerun
ckw017 Oct 5, 2021
e278025
Merge branch 'master' of github.com:ray-project/ray into reconnectflaky
ckw017 Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/ray/tests/test_client_reconnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ def disconnect(middleman):
disconnect_thread.join()


@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on windows")
def test_valid_actor_state():
"""
Repeatedly inject errors in the middle of mutating actor calls. Check
Expand Down Expand Up @@ -332,6 +333,7 @@ def fail_every_seven(_):
assert ray.get(ref) == 100


@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on windows")
def test_valid_actor_state_2():
"""
Do a full disconnect (cancel channel) every 11 requests. Failure
Expand Down