Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Skip test_valid_actor_state tests on windows #19114

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

ckw017
Copy link
Member

@ckw017 ckw017 commented Oct 5, 2021

Why are these changes needed?

Looks like there's an issue setting up the middleman server on windows ("Connection actively refused") on tests that are run after test_valid_actor_state, mark as flaky for now

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@AmeerHajAli AmeerHajAli added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 5, 2021
@ckw017 ckw017 changed the title [connect] Skip test_valid_actor_state tests on windows [client] Skip test_valid_actor_state tests on windows Oct 5, 2021
@ckw017 ckw017 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Oct 6, 2021
@AmeerHajAli AmeerHajAli merged commit db1105f into ray-project:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants