Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix bug in dependency resolution for actor handles #18862

Merged
merged 2 commits into from
Sep 29, 2021
Merged

[core] Fix bug in dependency resolution for actor handles #18862

merged 2 commits into from
Sep 29, 2021

Conversation

stephanie-wang
Copy link
Contributor

Why are these changes needed?

A bug in dependency resolution can cause a crash because the same task gets resolved/executed twice. This may happen if a task has actor and object dependencies.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 self-assigned this Sep 24, 2021
rkooo567
rkooo567 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bug that we don't check obj_dependencies_remaining so that on_complete can be called before all deps are resolved?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 27, 2021
@stephanie-wang stephanie-wang merged commit 5eddaab into ray-project:master Sep 29, 2021
@stephanie-wang
Copy link
Contributor Author

Is the bug that we don't check obj_dependencies_remaining so that on_complete can be called before all deps are resolved?

Yep, it can also lead to calling on_complete twice.

@stephanie-wang stephanie-wang deleted the async-actor-dep branch September 29, 2021 20:25
@stephanie-wang stephanie-wang mentioned this pull request Sep 29, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@fishbone fishbone Awaiting requested review from fishbone

Assignees

@rkooo567 rkooo567

@fishbone fishbone

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanie-wang @rkooo567 @fishbone