[Feature] Consistency check for RBAC #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
DmitriGekhtman
approved these changes
Sep 19, 2022
This was referenced Sep 19, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
This PR adds two consistency checks related to RBAC in GitHub Actions. (1) ray-operator-verify-crd-rbac: Kubebuilder markers in ray-operator/controllers/ray/*_controller.go should be synchronized with RBAC YAML files in ray-operator/config/rbac. (2) helm-chart-verify-rbac: Check the consistency between RBAC YAML files in helm-chart/kuberay-operator/templates and ray-operator/config/rbac.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds two consistency checks related to RBAC in GitHub Actions.
(1)
ray-operator-verify-crd-rbac: Kubebuilder markers inray-operator/controllers/ray/*_controller.goshould be synchronized with RBAC YAML files inray-operator/config/rbac.(2)
helm-chart-verify-rbac: Check the consistency between RBAC YAML files inhelm-chart/kuberay-operator/templatesandray-operator/config/rbac.Related issue number
Closes #580
Closes #164
Checks
This PR should pass CI/CD. (Link)
(DO NOT MERGE) #577 Control Group 1 #578
raycluster_controller.yaml.// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;deleteray-operator-verify-crd-rbacshould fail. (Link)(DO NOT MERGE) #577 Control Group 2 #579
raycluster_controller.yaml.// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;deletemake manifeststo synchronizeray-operator/config/rbac/role.yamland Kubebuilder markers.ray-operator-verify-crd-rbacshould pass, buthelm-chart-verify-rbacshould fail. (Link)