Add reminders to avoid RBAC synchronization bug #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
force-pushed
the
fix-kubebuilder-rbac
branch
from
21c516c to
5a0011c
Compare
2 tasks
Jeffwan
reviewed
Sep 20, 2022
| @@ -80,6 +80,7 @@ type RayClusterReconciler struct { | |||
| // +kubebuilder:rbac:groups="rbac.authorization.k8s.io",resources=roles,verbs=get;list;watch;create;delete;update | |||
| // +kubebuilder:rbac:groups="rbac.authorization.k8s.io",resources=rolebindings,verbs=get;list;watch;create;delete | |||
|
|
|||
| // [WARNING]: There MUST be a newline after kubebuilder markers. | |||
There was a problem hiding this comment.
em. is not line 82 a new line? I may forgot the tricks here.
There was a problem hiding this comment.
The new line is added by #577. Originally, it does not have a newline.
There was a problem hiding this comment.
I mean the new line was added in #577 and the bug should be fixed? This PR is to add some comment to reminder developer? But the title is the bug fix?
kevin85421
changed the title
Jeffwan
approved these changes
Sep 20, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In #164, @Jeffwan mentions that RBAC files cannot be updated automatically with the command
make manifests. The root cause is the lack of a newline after kubebuilder markers. This issue is same as kubernetes-sigs/controller-tools#551.In addition, the permissions of
config/rbac/role.yamlis the union of kubebuilder markers inraycluster_controller.go,rayjob_controller.go, andrayservice_controller.go.Related issue number
closes #164
Checks
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;deletemake manifestsconfig/role.yamlrole.yamlwill be updated.