Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): cache lfs download, run on PR only, always diff color #394

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Valentin271
Copy link
Member

Some improvements to the workflow added in #392.

  • lfs download is now cached
  • check PR workflow only run on PRs
  • diff should output with colors now (even in github CI)

@orhun
Copy link
Member

orhun commented Jan 23, 2024

Any idea why the CI is failing?

@Valentin271
Copy link
Member Author

Yeah, in #387 I "forgot" (there is actually no way to check that AFAIK) to check paragraph.png and paragraph.gif were uploaded on lfs.
I added a CI to check that in #392.
And #393 should fix the CI.

Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 967bb0f
Status: ✅  Deploy successful!
Preview URL: https://403a7910.ratatui.pages.dev
Branch Preview URL: https://fix-check-pr-ci.ratatui.pages.dev

View logs

@Valentin271
Copy link
Member Author

Rebased on main after merging #393 so the pipeline is now working.

@joshka joshka merged commit 83439fe into main Jan 24, 2024
8 checks passed
@joshka joshka deleted the fix/check-pr-ci branch January 24, 2024 11:35
@joshka joshka mentioned this pull request Jun 4, 2024
joshka pushed a commit that referenced this pull request Jun 4, 2024
#394)

* feat(list): add option to always allocate the "selection" column width

Before this option was available, selecting a item in a list when nothing was selected
previously made the row layout change (the same applies to unselecting) by adding the width
of the "highlight symbol" in the front of the list, this option allows to configure this
behavior.

* style: change "highlight_spacing" doc comment to use inline code-block for reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants