Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): check images are stored in lfs #392

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

Valentin271
Copy link
Member

PRs don't indicate whether images were uploaded using lfs or not.

This checks the images and gif are uploaded using lfs.

@kdheepak
Copy link
Contributor

We should also add instructions in the developer docs on how to upload images using lfs.

@Valentin271
Copy link
Member Author

Yeah that'd be nice. I'm thinking of adding them in #259. But I'm far from specialist in git lfs

@Valentin271 Valentin271 merged commit 04ae66c into main Jan 23, 2024
7 of 8 checks passed
@Valentin271 Valentin271 deleted the chore/compare-lfs branch January 23, 2024 15:19
@joshka joshka mentioned this pull request Jun 4, 2024
joshka pushed a commit that referenced this pull request Jun 4, 2024
* feat(table): enforce line alignment in table render

* test(table): add table alignment render test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants