Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CMake dependencies and build variables #23

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Remove unused CMake dependencies and build variables #23

merged 2 commits into from
Apr 6, 2023

Conversation

pentschev
Copy link
Member

Remove unused CUDA CMake dependencies and --build_metrics/--incl_cache_stats build configurations.

vyasr
vyasr approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming that removing the CUDA language is fine (which it appears to be from the build, just waiting on confirmation).

@pentschev
Copy link
Member Author

Yes, I believe all CUDA-related dependencies are resolved through RMM, since we only call RMM's host API. I was confused myself whether that was needed, but RMM-related tests pass without problems too, so I think we are in the clear.

@pentschev pentschev merged commit cb42216 into rapidsai:main Apr 6, 2023
@jakirkham jakirkham mentioned this pull request Apr 6, 2023
Closed
@pentschev pentschev deleted the build-and-cmake-changes branch April 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees

@vyasr vyasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pentschev @vyasr