-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAPIDS CPM headers inadvertently being installed #20
Comments
Think CPM is pulling in RMM (and therefore these other libraries). AFAIK they are not needed for this step. Is there a good way to disable them? |
Maybe we can just remove them manually for now ( #22 ). Likely some more work is needed on the CMake side |
The PR above should fix the issue. Though it would be good to understand why these headers are getting installed so that we can disable that behavior (as opposed to simply removing them afterwards). Reopening for follow up Edit: Retitled the issue to reflect this. Hope that is ok |
Possibly PR ( #23 ) has addressed some of the underlying issues. Might be worth rechecking things in a follow up to see what still needs to be done |
No, unfortunately not. Those changes were already in #18 where you saw the warnings. I only split those changes into a new PR to make #18 easier to review that PR and because that was not directly related to CI. |
Currently conda builds are fetching `rmm` from CPM, rather than using conda packages. This PR aims to use conda for as many dependencies as possible to avoid repackaging and clobbering issues. Resolves #20. Related to #22, #54, similar to rapidsai/cudf#13230 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/jakirkham - Peter Andreas Entschev (https://github.com/pentschev) - Ray Douglass (https://github.com/raydouglass) URL: #64
It appears that libucxx is shipping headers for spdlog, thrust, and cub. These headers should not be included in the libucxx package, but rather should be supplied by librmm or spdlog itself. We need to fix the conda dependency list to avoid including these files. It produces hundreds of lines of warnings in the CI output.
Example:
The text was updated successfully, but these errors were encountered: