-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move wheel building logic to downstream repos #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll hold off approving until everything is good on the downstream PRs, but this looks good to me.
vyasr
reviewed
Jul 18, 2023
vyasr
reviewed
Jul 18, 2023
vyasr
reviewed
Jul 18, 2023
…flows into local-script
ajschmidt8
reviewed
Jul 19, 2023
This was referenced Jul 19, 2023
vyasr
approved these changes
Jul 19, 2023
/merge |
vyasr
pushed a commit
that referenced
this pull request
Jul 20, 2023
I inadvertently broke workflows by forgetting to add `RAPIDS_ARTIFACT_DIR` in #97
vyasr
added a commit
that referenced
this pull request
Jul 21, 2023
This PR is the testing companion to #97. It also introduces a standardized publish workflow that may be reused between pure and manylinux builds (see #89). --------- Co-authored-by: Lawrence Mitchell <[email protected]> Co-authored-by: AJ Schmidt <[email protected]> Co-authored-by: Rick Ratzel <[email protected]>
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Jul 21, 2023
Depends on rapidsai/shared-workflows#97 Authors: - Divye Gala (https://github.com/divyegala) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - AJ Schmidt (https://github.com/ajschmidt8) URL: #1546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to minimize custom logic in wheel building workflows by trying to mirror conda builds closer and moving wheel building logic to downstream repositories. The PR achieves this by adding a new workflow
wheels-build.yaml
Depends on rapidsai/cibuildwheel-imgs#29