Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wheel building logic to downstream repos #97

Merged
merged 28 commits into from
Jul 19, 2023
Merged

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented May 23, 2023

This PR tries to minimize custom logic in wheel building workflows by trying to mirror conda builds closer and moving wheel building logic to downstream repositories. The PR achieves this by adding a new workflow wheels-build.yaml

Depends on rapidsai/cibuildwheel-imgs#29

@divyegala divyegala changed the base branch from branch-23.06 to branch-23.08 May 23, 2023 20:38
@divyegala divyegala changed the base branch from branch-23.08 to cuda-120 July 13, 2023 14:40
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll hold off approving until everything is good on the downstream PRs, but this looks good to me.

Base automatically changed from cuda-120 to branch-23.08 July 18, 2023 18:20
@divyegala divyegala marked this pull request as ready for review July 18, 2023 23:30
.github/workflows/wheels-build.yml Outdated Show resolved Hide resolved
.github/workflows/wheels-build.yml Outdated Show resolved Hide resolved
.github/workflows/wheels-build.yml Outdated Show resolved Hide resolved
.github/workflows/wheels-build.yml Outdated Show resolved Hide resolved
.github/workflows/wheels-build.yml Outdated Show resolved Hide resolved
@divyegala
Copy link
Member Author

/merge

@vyasr vyasr merged commit 016436c into branch-23.08 Jul 19, 2023
vyasr pushed a commit that referenced this pull request Jul 20, 2023
I inadvertently broke workflows by forgetting to add
`RAPIDS_ARTIFACT_DIR` in
#97
@vyasr vyasr deleted the local-script branch July 20, 2023 18:13
vyasr added a commit that referenced this pull request Jul 21, 2023
This PR is the testing companion to #97. It also introduces a
standardized publish workflow that may be reused between pure and
manylinux builds (see #89).

---------

Co-authored-by: Lawrence Mitchell <[email protected]>
Co-authored-by: AJ Schmidt <[email protected]>
Co-authored-by: Rick Ratzel <[email protected]>
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants