-
Notifications
You must be signed in to change notification settings - Fork 6
Add PIP_EXTRA_INDEX_URL
and gh
tool to build images
#29
Conversation
@ajschmidt8 could you re-review? I added |
gh
tool to build images
gh
tool to build imagesPIP_EXTRA_INDEX_URL
and gh
tool to build images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these changes install the gh
CLI via the OSes native package managers, the installed versions will likely be different.
To keep the versions consistent across our images, I think it might be better to install gh
using the artifacts on their release pages: https://github.com/cli/cli/releases.
It looks like they have a tarball for each architecture (arm64
and amd64
) that we can extract to get the actual gh
binary.
For now we can hardcode the version to their latest release, 2.32.0
.
When we move these images over to the rapidsai/ci-imgs
repository, we can configure the renovate
bot to open PRs to keep the version updated for us. See the references below for more about renovate
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming AJ's request regarding gh CLI installation is addressed.
Based on the logs, it looks like Ubuntu installed the latest version (which is expected since you added the PPA), but CentOS actually didn't install any version at all: |
@ajschmidt8 do you know off the top of your head where should I unpack these tarballs so |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's check the GHAs logs before merging this to make sure they look right, but this looks good to me.
This reverts commit c222ca0.
This PR tries to minimize custom logic in wheel building workflows by trying to mirror conda builds closer and moving wheel building logic to downstream repositories. The PR achieves this by adding a new workflow `wheels-build.yaml` Depends on rapidsai/cibuildwheel-imgs#29 --------- Co-authored-by: Vyas Ramasubramani <[email protected]>
Depends on rapidsai/gha-tools#57
This PR adds:
PIP_EXTRA_INDEX_URL
: Environment variable for RAPIDS wheels indexgh
: CLI tool to generateRAPIDS_DATE_STRING