Fix PoolMemoryResource Python doc examples [skip-ci] #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
doc
shwina
reviewed
Jun 16, 2021
| @@ -103,7 +103,7 @@ of 1 GiB and a maximum size of 4 GiB. The pool uses | |||
| ```python | |||
| >>> import rmm | |||
| >>> pool = rmm.mr.PoolMemoryResource( | |||
| ... upstream=rmm.mr.CudaMemoryResource(), | |||
There was a problem hiding this comment.
Just FYI, you can still use arg_name= for positional arguments to be more explicit. The error here was because the argument name is wrong. The following would work:
pool = rmm.mr.PoolMemoryResource(
...: ... upstream_mr=rmm.mr.CudaMemoryResource(), # not "upstream"
...: ... initial_pool_size=2**30,
...: ... maximum_pool_size=2**32)
There was a problem hiding this comment.
Darn, that would have been a nicer fix.
shwina
approved these changes
Jun 16, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805. Removes
upstream=because the API requires at least one positional parameter.