We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location of incorrect documentation Incorrect code examples for PoolMemoryResource at:
Incorrect code:
import rmm pool = rmm.mr.PoolMemoryResource( upstream=rmm.mr.CudaMemoryResource(), initial_pool_size=2**30, maximum_pool_size=2**32) rmm.mr.set_current_device_resource(pool)
Describe the problems or issues found in the documentation
The code example gives the following error:
--------------------------------------------------------------------------- TypeError Traceback (most recent call last) <ipython-input-4-7cd0585a0d02> in <module> 1 import rmm ----> 2 pool = rmm.mr.PoolMemoryResource( 3 upstream=rmm.mr.CudaMemoryResource(), 4 initial_pool_size=2**30, 5 maximum_pool_size=2**32) rmm/_lib/memory_resource.pyx in rmm._lib.memory_resource.UpstreamResourceAdaptor.__cinit__() TypeError: __cinit__() takes at least 1 positional argument (0 given)
Steps taken to verify documentation is incorrect Run the code example above.
Suggested fix for documentation Remove the upstream keyword.
upstream
import rmm pool = rmm.mr.PoolMemoryResource( rmm.mr.CudaMemoryResource(), initial_pool_size=2**30, maximum_pool_size=2**32) rmm.mr.set_current_device_resource(pool)
The text was updated successfully, but these errors were encountered:
Fix PoolMemoryResource Python doc examples (#807)
f697222
Fixes #805. Removes `upstream=` because the API requires at least one positional parameter. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #807
Successfully merging a pull request may close this issue.
Report incorrect documentation
Location of incorrect documentation
Incorrect code examples for PoolMemoryResource at:
Incorrect code:
Describe the problems or issues found in the documentation
The code example gives the following error:
Steps taken to verify documentation is incorrect
Run the code example above.
Suggested fix for documentation
Remove the
upstream
keyword.The text was updated successfully, but these errors were encountered: