Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe #705

Merged
merged 6 commits into from
Feb 22, 2021
Merged

[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe #705

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e0301c9
ENH Build with Ninja & Pass ccache variables to conda recipe
dillon-cullinan Feb 16, 2021
053e80d
FIX Fix indentation
dillon-cullinan Feb 16, 2021
6c29651
TST List ccache dir
dillon-cullinan Feb 16, 2021
b773d44
TST Fix testt
dillon-cullinan Feb 16, 2021
563141a
TST Revert testing changes
dillon-cullinan Feb 16, 2021
2d2ea83
FIX Remove unnecessary compiler vars, export generator in build.sh
dillon-cullinan Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,13 @@ function ensureCMakeRan {
mkdir -p "${LIBRMM_BUILD_DIR}"
if (( RAN_CMAKE == 0 )); then
echo "Executing cmake for librmm..."
cmake -DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \
cmake -GNinja \
dillon-cullinan marked this conversation as resolved.
Show resolved Hide resolved
-DCMAKE_INSTALL_PREFIX="${INSTALL_PREFIX}" \
-DCUDA_STATIC_RUNTIME="${CUDA_STATIC_RUNTIME}" \
-DPER_THREAD_DEFAULT_STREAM="${PER_THREAD_DEFAULT_STREAM}" \
-DCMAKE_C_COMPILER_LAUNCHER="${CMAKE_C_COMPILER_LAUNCHER}" \
dillon-cullinan marked this conversation as resolved.
Show resolved Hide resolved
-DCMAKE_CXX_COMPILER_LAUNCHER="${CMAKE_CXX_COMPILER_LAUNCHER}" \
-DCMAKE_CUDA_COMPILER_LAUNCHER="${CMAKE_CUDA_COMPILER_LAUNCHER}" \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} -B "${LIBRMM_BUILD_DIR}" -S .
RAN_CMAKE=1
fi
Expand Down
7 changes: 7 additions & 0 deletions conda/recipes/librmm/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ build:
- CUDAHOSTCXX
- PARALLEL_LEVEL
- VERSION_SUFFIX
- CCACHE_DIR
- CCACHE_NOHASHDIR
- CCACHE_COMPILERCHECK
- CMAKE_GENERATOR
- CMAKE_C_COMPILER_LAUNCHER
- CMAKE_CXX_COMPILER_LAUNCHER
- CMAKE_CUDA_COMPILER_LAUNCHER
Comment on lines +21 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really make a rapids-build package or something similar that sets these via an activation script instead of passing all of these through the recipe, but we can do that in follow ups I suppose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what you mean. Are you talking about utilizing this: https://conda.io/projects/conda-build/en/latest/resources/activate-scripts.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, we could have a package with an activate script that sets all of these environment variables as expected and then depend on the package in the build section or something similar.

run_exports:
- {{ pin_subpackage("librmm", max_pin="x.x") }}

Expand Down