[REVIEW] ENH Build with Ninja & Pass ccache variables to conda recipe #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjacobelli
approved these changes
Feb 16, 2021
|
rerun tests |
dillon-cullinan
added
improvement
dillon-cullinan
changed the title
harrism
requested changes
Feb 16, 2021
kkraus14
reviewed
Feb 19, 2021
Comment on lines
+21
to
+27
| - CCACHE_DIR | ||
| - CCACHE_NOHASHDIR | ||
| - CCACHE_COMPILERCHECK | ||
| - CMAKE_GENERATOR | ||
| - CMAKE_C_COMPILER_LAUNCHER | ||
| - CMAKE_CXX_COMPILER_LAUNCHER | ||
| - CMAKE_CUDA_COMPILER_LAUNCHER |
There was a problem hiding this comment.
We should really make a rapids-build package or something similar that sets these via an activation script instead of passing all of these through the recipe, but we can do that in follow ups I suppose.
There was a problem hiding this comment.
I'm not sure I understand what you mean. Are you talking about utilizing this: https://conda.io/projects/conda-build/en/latest/resources/activate-scripts.html
There was a problem hiding this comment.
Yes exactly, we could have a package with an activate script that sets all of these environment variables as expected and then depend on the package in the build section or something similar.
kkraus14
approved these changes
Feb 19, 2021
harrism
approved these changes
Feb 22, 2021
|
@gpucibot merge |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ninjabuild systemccacheenvironment variables to the conda buildThese changes are required to allow
ccacheto function correctly and have a high cache hitrate during builds.