Just use None for strides in DeviceBuffer
#477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
kkraus14
approved these changes
Aug 11, 2020
kkraus14
added
5 - Ready to Merge
|
Looks like something is segfaulting here which is a bit concerning. I'm guessing it's unrelated to this PR. |
jakirkham
force-pushed
the
use_contiguous_strides
branch
from
aeadb9a to
06949e3
Compare
Originally there were some issues in CuPy and Numba with how they implemented `__cuda_array_interface__` and handled other objects that supported it where they couldn't handle `strides` of `None` cleanly. So we added `strides` here with what it should be. However both libraries have since cleaned this up (CuPy 6.6.0+ and Numba 0.46.0+) and we require newer versions of both. As some code contains fast paths when `strides` is `None`, switch to using `None` here as we ensure contiguous data in `DeviceBuffer`s. This should allow us to take advantage of those fast paths where possible.
jakirkham
force-pushed
the
use_contiguous_strides
branch
from
06949e3 to
0254df3
Compare
|
Yeah I've seen that before if the tests fail. Probably something not being cleaned up properly. |
This was referenced Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally there were some issues in CuPy and Numba with how they implemented
__cuda_array_interface__and handled other objects that supported it where they couldn't handlestridesofNonecleanly. So we addedstrideshere with what it should be. However both libraries have since cleaned this up ( CuPy 6.6.0+, cupy/cupy#2669 and Numba 0.46.0+, numba/numba#4609 ) and we require newer versions of both. As some code contains fast paths whenstridesisNone, switch to usingNonehere as we ensure contiguous data inDeviceBuffers. This should allow us to take advantage of those fast paths where possible.