Always set RMM's strides in the header
#4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As newer versions of RMM have `DeviceBuffer` setting `strides` in `__cuda_array_interface__` to `None` (as they are C-contiguous) and some deserializers rely on this to be a non-`None` value, make sure to just explicitly set `strides` to a non-`None` value.
|
Going to go ahead and merge to fix UCX-Py CI. Only affects RMM serialization. |
|
Going to go ahead and merge to fix UCX-Py CI. Only affects RMM
serialization.
From my perspective RAPIDS folks should feel free reign to self-merge in
UCX/RMM land
…On Tue, Aug 11, 2020 at 5:26 PM jakirkham ***@***.***> wrote:
Merged #4039 <#4039> into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4039 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTBJYP3YPZML3ZT553TSAHORXANCNFSM4P3XHPHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR ( rapidsai/rmm#477 )
Fixes this test failure ( rapidsai/ucx-py#575 (comment) )
As newer versions of RMM have
DeviceBuffersettingstridesin__cuda_array_interface__toNone(as they are C-contiguous) and some deserializers rely on this to be a non-Nonevalue, make sure to just explicitly setstridesto a non-Nonevalue.