Stop using versioneer to manage versions #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
2 - In Progress
vyasr
force-pushed
the
feat/remove_versioneer
branch
from
a8c6caa to
e6fc0cb
Compare
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1190 +/- ##
=============================================
Coverage 0.00% 0.00%
=============================================
Files 6 5 -1
Lines 421 140 -281
=============================================
+ Misses 421 140 -281
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdice
reviewed
Jan 18, 2023
3 tasks
vyasr
force-pushed
the
feat/remove_versioneer
branch
from
e6fc0cb to
ab82618
Compare
vyasr
force-pushed
the
feat/remove_versioneer
branch
from
d569446 to
3d8687f
Compare
vyasr
added
3 - Ready for review
bdice
approved these changes
Feb 16, 2023
3 tasks
sevagh
approved these changes
Feb 16, 2023
|
@vyasr, the Please re-comment this PR with |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
…1212) The package name defined in setup.py needs to be modified for wheels to reflect the CUDA version that the wheel was built for. Currently that modification is done via an environment variable that is pulled in setup.py code. This changeset replaces that approach with a direct modification using a script (similar to what is done for versions in #1190) to facilitate moving towards static project metadata specification via pyproject.toml. This PR depends on rapidsai/shared-workflows#45. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Sevag H (https://github.com/sevagh) - Ashwin Srinath (https://github.com/shwina) URL: #1212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces usage of versioneer with hard-coded version numbers in setup.py and init.py. Since rmm needs to manage versions across a wide range of file types (CMake, C++, Sphinx and doxygen docs, etc), versioneer cannot be relied on as a single source of truth and therefore does not allow us to single-source our versioning to the Git repo as is intended. Additionally, since the primary means of installing rmm is via conda packages (or now, pip packages), information from the package manager tends to be far more informative than the version strings for troubleshooting and debugging purposes. Conversely, the nonstandard version strings that it produces tend to be problematic for other tools, which at best will ignore such versions but at worst will simply fail.
Relies on rapidsai/shared-workflows#38
Checklist