Use script rather than environment variable to modify package names (#…

…1212)

The package name defined in setup.py needs to be modified for wheels to reflect the CUDA version that the wheel was built for. Currently that modification is done via an environment variable that is pulled in setup.py code. This changeset replaces that approach with a direct modification using a script (similar to what is done for versions in #1190) to facilitate moving towards static project metadata specification via pyproject.toml.

This PR depends on rapidsai/shared-workflows#45.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Sevag H (https://github.com/sevagh)
  - Ashwin Srinath (https://github.com/shwina)

URL: #1212

.github/workflows/build.yaml

@@ -74,7 +74,7 @@ jobs:
       package-name: rmm
       package-dir: python
       skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
-      uses-versioneer: false
+      uses-setup-env-vars: false
   wheel-publish:
     needs: wheel-build
     secrets: inherit

.github/workflows/pr.yaml

@@ -68,7 +68,7 @@ jobs:
       package-dir: python
       package-name: rmm
       skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
-      uses-versioneer: false
+      uses-setup-env-vars: false
   wheel-tests:
     needs: wheel-build
     secrets: inherit

ci/release/apply_wheel_modifications.sh

@@ -4,6 +4,9 @@
 # Usage: bash apply_wheel_modifications.sh <new_version>
 
 VERSION=${1}
+CUDA_SUFFIX=${2}
 
 sed -i "s/__version__ = .*/__version__ = \"${VERSION}\"/g" python/rmm/__init__.py
 sed -i "s/version=.*,/version=\"${VERSION}\",/g" python/setup.py
+
+sed -i "s/name=\"rmm\",/name=\"rmm${CUDA_SUFFIX}\",/g" python/setup.py

python/setup.py

@@ -1,12 +1,10 @@
 # Copyright (c) 2019-2022, NVIDIA CORPORATION.
 
-import os
-
 from setuptools import find_packages
 from skbuild import setup
 
 setup(
-    name="rmm" + os.getenv("RAPIDS_PY_WHEEL_CUDA_SUFFIX", default=""),
+    name="rmm",
     version="23.04.00",
     description="rmm - RAPIDS Memory Manager",
     url="https://github.com/rapidsai/rmm",