Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Include attempted allocation size in rmm::out_of_memory #1134

Open
abellina opened this issue Oct 21, 2022 · 0 comments
Open

[FEA] Include attempted allocation size in rmm::out_of_memory #1134

abellina opened this issue Oct 21, 2022 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@abellina
Copy link
Contributor

abellina commented Oct 21, 2022

It would be useful if rmm::out_of_memory exceptions could include the attempted allocation size that failed.

"Maximum pool size exceeded (failed to allocate X MiB)"

I am thinking it could just be in the msg, but perhaps it could be added as metadata in the out_of_memory class? I am not entirely sure.

ASYNC relevant code:

RMM_EXPECTS(size <= this->underlying().get_maximum_allocation_size(),

ARENA relevant code:

RMM_FAIL("Maximum pool size exceeded", rmm::out_of_memory);

The change should also include other allocators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant