Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nvcomp to 4.1.0.6 #709

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Upgrade nvcomp to 4.1.0.6 #709

merged 2 commits into from
Oct 30, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 28, 2024

Description

This PR updates the nvcomp version pinning to 4.1.0.6.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice added feature request New feature or request non-breaking Introduces a non-breaking change labels Oct 28, 2024
bdice
bdice commented Oct 28, 2024
View reviewed changes
rapids-cmake/cpm/versions.json Outdated Show resolved Hide resolved
This was referenced Oct 29, 2024
Merged
Merged
@bdice
Copy link
Contributor Author

bdice commented Oct 29, 2024

Testing downstream in cudf and kvikio:

@bdice
Copy link
Contributor Author

bdice commented Oct 30, 2024

Downstream testing passed. Opening for review.

@bdice bdice marked this pull request as ready for review October 30, 2024 13:10
@bdice bdice requested a review from a team as a code owner October 30, 2024 13:10
robertmaynard
robertmaynard approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They changed the urls again, fun 👍

@bdice
Copy link
Contributor Author

bdice commented Oct 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit f5f793a into rapidsai:branch-24.12 Oct 30, 2024
15 checks passed
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Oct 30, 2024
@bdice
Upgrade nvcomp to 4.1.0.6 (#525)
607c6a5 
This updates cudf to use nvcomp 4.1.0.6.

The version is updated in rapids-cmake in rapidsai/rapids-cmake#709.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #525
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Oct 30, 2024
@bdice
Upgrade nvcomp to 4.1.0.6 (#17201)
6c2eb4e 
This updates cudf to use nvcomp 4.1.0.6.

The version is updated in rapids-cmake in rapidsai/rapids-cmake#709.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #17201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @robertmaynard