-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nvcomp to 4.1.0.6 #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me like this is not ready yet. From wheel tests:
Module 'kvikio.zarr' was found, but when imported by pytest it raised:
ImportError('/pyenv/versions/3.10.15/lib/python3.10/site-packages/kvikio/_lib/libnvcomp.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN6nvcomp14BitcompManagerC1EmRK30nvcompBatchedBitcompFormatOptsP11CUstream_stiNS_14ChecksumPolicyENS_13BitstreamKindE')
Maybe |
@jameslamb Sorry for my lack of communication here. This is only failing now because I reverted rapids-cmake testing changes in 62265bb. The tests passed in 45e7389. I am going to rerun CI after merging the rapids-cmake PR, but you can review the CI run from the previous commit. |
Also: We have the nvcomp wheel dependency we need here: kvikio/python/kvikio/pyproject.toml Line 25 in 62265bb
libkvikio is header-only, and the nvcomp dependency is really in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok got it, I misunderstood what was happening there. Thanks for the explanation.
/merge |
This updates cudf to use nvcomp 4.1.0.6.
The version is updated in rapids-cmake in rapidsai/rapids-cmake#709.