Upgrade nvcomp to 4.0.1 #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
|
URL form for nvcomp 4.0 has changed we need Likewise for x86 which is now |
|
Going to look at the changes required in rapids-cmake to support these new url strings later today |
…er CUDA version mapping Allows us to support download urls that have unique mappings per CUDA major version
|
More changes are required as the nvcomp 4.0 cmake package has a different set of files which needs to be patched for a proper install layout |
3 tasks
|
Waiting on https://github.com/rapidsai/cudf/pull/16076/files being ready to merge |
|
Blocked due to nvcomp now having a hard libcuda.so dependency. |
3 tasks
bdice
approved these changes
Sep 5, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Sep 5, 2024
Update the nvCOMP version used for compression/decompression to 4.0.1. See also: rapidsai/rapids-cmake#633 rapidsai/cudf#16076 Depends on #450. Authors: - Vukasin Milovanovic (https://github.com/vuule) - Bradley Dice (https://github.com/bdice) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) - Bradley Dice (https://github.com/bdice) URL: #449
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 5, 2024
This PR bumps nvcomp to 4.0.1. Depends on: - conda-forge/nvcomp-feedstock#15 - rapidsai/rapids-cmake#633 - rapidsai/kvikio#449 Authors: - Vukasin Milovanovic (https://github.com/vuule) - Robert Maynard (https://github.com/robertmaynard) - Peixin (https://github.com/pxLi) - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) URL: #16076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to nvcomp 4.0. As part of that change we need to refactor the
nvcomp.cmaketo be aware of the new CMake files and targets that nvcomp generates.Checklist