Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to nvcomp 4.0.1 #16076

Merged
merged 27 commits into from
Sep 5, 2024
Merged

Upgrade to nvcomp 4.0.1 #16076

merged 27 commits into from
Sep 5, 2024

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jun 24, 2024 •
edited
Loading

Description

This PR bumps nvcomp to 4.0.1.

Depends on:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added feature request New feature or request non-breaking Non-breaking change labels Jun 24, 2024
@vuule vuule self-assigned this Jun 24, 2024
@github-actions github-actions bot added the CMake CMake build issue label Jun 24, 2024
This was referenced Jul 11, 2024
Closed
Merged
robertmaynard
robertmaynard requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL form for nvcomp 4.0 has changed we need nvcomp-linux-sbsa-4.0.0-cuda12.5.tar.gz instead of nvcomp_4.0.0_SBSA_12.x.tgz

Likewise for x86 which is now nvcomp-linux-x86_64-4.0.0-cuda12.5.tar.gz

@robertmaynard
Copy link
Contributor

I am going to look more at this given the challenges of figuring out the correct url now for CUDA 11 versus CUDA 12

@robertmaynard robertmaynard self-requested a review July 19, 2024 19:12
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 22, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 22, 2024
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jul 22, 2024
@robertmaynard
Copy link
Contributor

Updated to include the changes from #16250

@robertmaynard robertmaynard changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 13:52
@vuule vuule changed the title [test] upgrade to nvcomp 4.0 [test] upgrade to nvcomp 4.0.1 Aug 27, 2024
@jakirkham
Copy link
Member

Think we will need PR: conda-forge/nvcomp-feedstock#15

bdice
bdice reviewed Aug 28, 2024
View reviewed changes
cpp/cmake/thirdparty/get_nvcomp.cmake Outdated Show resolved Hide resolved
java/src/main/native/CMakeLists.txt Show resolved Hide resolved
rapids_config.cmake Outdated Show resolved Hide resolved
@vuule vuule requested review from a team as code owners September 4, 2024 20:29
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 4, 2024
@ttnghia ttnghia added breaking Breaking change non-breaking Non-breaking change and removed non-breaking Non-breaking change breaking Breaking change labels Sep 4, 2024
bdice
bdice approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We will need a final approval from @robertmaynard since he requested changes earlier. (Also, this is a reminder to revert the rapids-cmake branch changes before merging.)

@bdice bdice force-pushed the fea-test-nvcomp-4.0 branch from c04e105 to ce03947 Compare September 5, 2024 20:05
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 5, 2024
@bdice
Copy link
Contributor

bdice commented Sep 5, 2024

/merge

@bdice bdice mentioned this pull request Sep 5, 2024
Closed
rapids-bot bot pushed a commit to rapidsai/kvikio that referenced this pull request Sep 5, 2024
@vuule
Update nvcomp to 4.0.1 (#449)
59edda0 
Update the nvCOMP version used for compression/decompression to 4.0.1.

See also:

rapidsai/rapids-cmake#633
rapidsai/cudf#16076

Depends on #450.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mads R. B. Kristensen (https://github.com/madsbk)
  - Bradley Dice (https://github.com/bdice)

URL: #449
@rapids-bot rapids-bot bot merged commit 0cc059f into rapidsai:branch-24.10 Sep 5, 2024
85 checks passed
gerashegalov added a commit to gerashegalov/cudf that referenced this pull request Oct 2, 2024
@gerashegalov
Revert "Upgrade to nvcomp 4.0.1 (rapidsai#16076)"
f028292 
This reverts commit 0cc059f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vuule vuule

Labels
CMake CMake build issue feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vuule @robertmaynard @jakirkham @bdice @ttnghia @pxLi