Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that ctest is called with --no-tests=error. #535

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Ensure that ctest is called with --no-tests=error. #535

merged 2 commits into from
Feb 7, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 7, 2024

This PR ensures that all calls to ctest include the flag --no-tests=error. See rapidsai/build-planning#18.

@bdice bdice requested a review from a team as a code owner February 7, 2024 00:30
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 7, 2024
@bdice bdice mentioned this pull request Feb 7, 2024
Closed
KyleFromNVIDIA
KyleFromNVIDIA requested changes Feb 7, 2024
View reviewed changes
ci/test_cpp.sh Show resolved Hide resolved
@KyleFromNVIDIA KyleFromNVIDIA self-requested a review February 7, 2024 13:52
@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 46ad1bb into rapidsai:branch-24.04 Feb 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @KyleFromNVIDIA