Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ctest is called with --no-tests=error. #18

Closed
bdice opened this issue Feb 6, 2024 · 2 comments
Closed

Ensure ctest is called with --no-tests=error. #18

bdice opened this issue Feb 6, 2024 · 2 comments

Comments

@bdice
Copy link
Contributor

bdice commented Feb 6, 2024

Following up from rapidsai/rapids-cmake#534 and rapidsai/cuml#5753.

We should ensure that ctest is called with the flag --no-tests=error. This would help prevent false positives in RAPIDS C++ test suites. @KyleFromNVIDIA also proposed adding a pre-commit hook to enforce this.
This was referenced Feb 7, 2024
Merged
Merged
Closed
Merged
Merged
Merged
@bdice
Copy link
Contributor Author

bdice commented Feb 7, 2024 •
edited
Loading

We should be good once these merge. @KyleFromNVIDIA feel free to add a pre-commit hook to verify this for the future.

rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this issue Feb 7, 2024
@bdice
Ensure that ctest is called with --no-tests=error. (#535)
46ad1bb 
This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See rapidsai/build-planning#18.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #535
@bdice bdice mentioned this issue Feb 7, 2024
Merged
3 tasks
rapids-bot bot pushed a commit to rapidsai/rmm that referenced this issue Feb 7, 2024
@bdice
Ensure that ctest is called with --no-tests=error. (#1460)
49f7058 
This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See rapidsai/build-planning#18.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1460
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this issue Feb 7, 2024
@bdice
Ensure that ctest is called with --no-tests=error. (#4148)
f9e618b 
This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See rapidsai/build-planning#18.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4148
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this issue Feb 7, 2024
@bdice
Ensure that ctest is called with --no-tests=error. (#14983)
63a1c9e 
This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See rapidsai/build-planning#18.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #14983
rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Mar 5, 2024
@bdice
Ensure that ctest is called with --no-tests=error. (#2163)
054731d 
This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See rapidsai/build-planning#18.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #2163
@bdice
Copy link
Contributor Author

bdice commented Mar 25, 2024

I'm going to close since all the PRs were merged. The unfinished item here is to potentially add a pre-commit hook that verifies this for repos. @KyleFromNVIDIA If you are still interested in doing that, feel free.

@bdice bdice closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdice