Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out if generate_ctest_json fails to build or run #533

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Error out if generate_ctest_json fails to build or run #533

merged 10 commits into from
Feb 7, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Feb 6, 2024 •
edited by bdice
Loading

Description

Additionally, allow for multiple CUDA include directories by prepending a -I to each directory.

Fixes: #421
Fixes: #534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner February 6, 2024 22:52
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change labels Feb 6, 2024
@bdice bdice mentioned this pull request Feb 6, 2024
Merged
@robertmaynard
Copy link
Contributor

rapidsai/raft#2161 validates that these changes correct no tests running in RAFT C++ CI test jobs.

@raydouglass raydouglass merged commit 96bc839 into rapidsai:branch-24.02 Feb 7, 2024
16 of 17 checks passed
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Feb 7, 2024
Closed
This was referenced Feb 7, 2024
Merged
Merged
raydouglass pushed a commit to rapidsai/raft that referenced this pull request Feb 9, 2024
@cjnolet
Fix failing C++ tests and revert #2097, #2085. (#2168)
9446430 
RAFT C++ tests were not running for a portion of the 24.02 development cycle, until the merger of rapidsai/rapids-cmake#533.

This PR fixes some failing tests and reverts PRs that caused test failures that were silent until now, specifically #2097 and #2085. These features will be revisited in a subsequent release.

Authors:
   - Malte Förster (https://github.com/mfoerste4)
   - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
   - Ben Frederickson (https://github.com/benfred)
   - Bradley Dice (https://github.com/bdice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @robertmaynard @raydouglass