Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Error when generating test file for install_relocatable fails #421

Closed
vyasr opened this issue Jun 6, 2023 · 0 comments
Closed

[FEA] Error when generating test file for install_relocatable fails #421

vyasr opened this issue Jun 6, 2023 · 0 comments
Assignees
@vyasr
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Jun 6, 2023

When generate_ctest_json is not properly created during the CMake configure for the build, we should error instead of silently allowing the configure to complete. Now that most of RAPIDS relies on running tests with ctest, those test runs will fail if the file doesn't exist.
@vyasr vyasr added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 6, 2023
@vyasr vyasr self-assigned this Jun 6, 2023
KyleFromNVIDIA added a commit to KyleFromNVIDIA/rapids-cmake that referenced this issue Feb 6, 2024
@KyleFromNVIDIA
Error out if generate_ctest_json fails to build or run
e0e7d9f 
Fixes: rapidsai#421
KyleFromNVIDIA added a commit to KyleFromNVIDIA/rapids-cmake that referenced this issue Feb 6, 2024
@KyleFromNVIDIA
Error out if generate_ctest_json fails to build or run
368796c 
Fixes: rapidsai#421
@KyleFromNVIDIA KyleFromNVIDIA mentioned this issue Feb 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasr vyasr

Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vyasr