-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fea/support cmake cuda architectures rapids value #327
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-23.02
from
robertmaynard:fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
Jan 4, 2023
Merged
Fea/support cmake cuda architectures rapids value #327
rapids-bot
merged 6 commits into
rapidsai:branch-23.02
from
robertmaynard:fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
New feature or request
non-breaking
Introduces a non-breaking change
3 - Ready for Review
Ready for review by team
labels
Dec 8, 2022
bdice
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed? There is no description or linked issue that I can see.
robertmaynard
force-pushed
the
fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
branch
from
December 19, 2022 18:37
46ab0da
to
b33a3ba
Compare
bdice
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@gpucibot merge |
robertmaynard
deleted the
fea/support-CMAKE_CUDA_ARCHITECTURES-RAPIDS-value
branch
January 4, 2023 13:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
feature request
New feature or request
non-breaking
Introduces a non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMake 3.23+ now offers support for
all
andall-major
as special keywords toCMAKE_CUDA_ARCHITECTURES
. This means that rapids-cmake overload onALL
now creates confusion and breaks expectations ( trxcllnt/rapids-compose#84 https://gitlab.kitware.com/cmake/cmake/-/issues/23739, #104 )This PR introduces the new magic keyword of
RAPIDS
which behaves the same asALL
, and will become the new apporved approach for projects that want to build for RAPIDS supported platforms.Fixes #314
More details on the plans of deprecation for
ALL
can be found at: #318Checklist
cmake-format.json
is up to date with these changes.