Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values #318

Open
4 of 6 tasks
robertmaynard opened this issue Dec 1, 2022 · 0 comments
Open
4 of 6 tasks

[EPIC] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values #318

robertmaynard opened this issue Dec 1, 2022 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@robertmaynard
Copy link
Contributor

robertmaynard commented Dec 1, 2022 •
edited
Loading

Issue
The overloads of NATIVE, ALL, and "" for CMAKE_CUDA_ARCHITECTURES have resulted in confusion with the CMake 3.24+ feature of offering native, all, all-major.

#318 (comment)
@robertmaynard robertmaynard added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 1, 2022
@robertmaynard robertmaynard changed the title [FEA] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values [Meta] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values Dec 1, 2022
@robertmaynard robertmaynard changed the title [Meta] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values [EPIC] Revamp rapids-cmake handling of CMAKE_CUDA_ARCHITECTURE magic values Dec 1, 2022
@robertmaynard robertmaynard mentioned this issue Dec 13, 2022
Merged
4 tasks
rapids-bot bot pushed a commit that referenced this issue Jan 4, 2023
@robertmaynard
Fea/support cmake cuda architectures rapids value (#327)
49a9ced 
CMake 3.23+ now offers support for `all` and `all-major` as special keywords to `CMAKE_CUDA_ARCHITECTURES`. This means that rapids-cmake overload on `ALL` now creates confusion and breaks expectations ( trxcllnt/rapids-compose#84 https://gitlab.kitware.com/cmake/cmake/-/issues/23739, #104 ) 

This PR introduces the new magic keyword of `RAPIDS` which behaves the same as `ALL`, and will become the new apporved approach for projects that want to build for RAPIDS supported platforms.

Fixes #314


More details on the plans of deprecation for `ALL` can be found at: #318

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
rapids-cmake
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robertmaynard