Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the concept of a patches to apply to a project built via CPM #264

Merged
merged 6 commits into from
Sep 19, 2022
Merged

Support the concept of a patches to apply to a project built via CPM #264

merged 6 commits into from
Sep 19, 2022

Conversation

robertmaynard
Copy link
Contributor

This will allow us to apply critical patches to projects such as thrust, and nvcomp

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Sep 8, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner September 8, 2022 15:27
@robertmaynard
Copy link
Contributor Author

We will want to update CPM once cpm-cmake/CPM.cmake#401 has been merged so users don't get CMake warnings after a patch has been applied.

@robertmaynard
Support the concept of a patches to apply to a project built via CPM
8ea299a 
This will allow us to apply critical patches to projects such as thrust, and nvcomp
@robertmaynard robertmaynard force-pushed the fea/support_patching_cpm_projects branch from ed06f1a to 8ea299a Compare September 8, 2022 15:36
@robertmaynard robertmaynard mentioned this pull request Sep 8, 2022
Merged
@robertmaynard robertmaynard added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 9, 2022
bdice
bdice approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments -- I'd like to merge this PR to introduce the patching infrastructure before merging #265.

docs/packages/patches.json Show resolved Hide resolved
rapids-cmake/cpm/package_override.cmake Show resolved Hide resolved
rapids-cmake/cpm/patches/command_template.cmake.in Outdated Show resolved Hide resolved
@robertmaynard robertmaynard removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 19, 2022
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e8e33f6 into rapidsai:branch-22.10 Sep 19, 2022
@robertmaynard robertmaynard deleted the fea/support_patching_cpm_projects branch September 19, 2022 13:32
rapids-bot bot pushed a commit that referenced this pull request Oct 3, 2022
@robertmaynard
Switch thrust over to use rapids-cmake patches (#265)
4102c93 
Leverages the infrastructure of #264 to switch rapids_cpm_thrust over to using the built-in patch support.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice