Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about dirty source trees when a PATCH_COMMAND is provided #401

Conversation

robertmaynard
Copy link
Contributor

The patch command will always cause a dirty source tree, which is expected and not a cause for concern.

The patch command will always cause a dirty source tree, which
is expected and not a cause for concern.
Copy link
Member

@iboB iboB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks for the PR!

@TheLartians TheLartians merged commit 63d0de7 into cpm-cmake:master Sep 13, 2022
@robertmaynard robertmaynard deleted the dont_warn_about_dirty_when_patch_command branch September 19, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants