rapids_cpm_gtest will properly find GTest 1.10 packages #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if CMake < 3.23 was installed the provided FindGTest would be used which doesn't provide the GMock targets. In addition in those cases, since we pass EXACT we need to ensure we also exactly match the patch version of GTest.
robertmaynard
added
bug
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Mar 22, 2022
…565) Fixes errors configuring RAFT now that rapids-cmake [is enforcing](rapidsai/rapids-cmake#168) GTest v1.10.0. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if CMake < 3.23 was installed the provided FindGTest
would be used which doesn't provide the GMock targets.
In addition in those cases, since we pass EXACT we need to ensure we also exactly match the patch version of GTest.