Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Don't add gtest to build export set or generate a gtest-config.cmake #565

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

trxcllnt
Copy link
Collaborator

Fixes errors configuring RAFT now that rapids-cmake is enforcing GTest v1.10.0.

@trxcllnt trxcllnt requested a review from a team as a code owner March 18, 2022 19:18
@trxcllnt trxcllnt added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2022
@cjnolet
Copy link
Member

cjnolet commented Mar 22, 2022

rerun tests

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Mar 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1c54493 into rapidsai:branch-22.04 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants