Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically sync handle when not passed to pylibraft functions #987

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Automatically sync handle when not passed to pylibraft functions #987

merged 4 commits into from
Nov 7, 2022

Conversation

benfred
Copy link
Member

@benfred benfred commented Nov 3, 2022

Closes #971

@benfred benfred requested a review from a team as a code owner November 3, 2022 23:51
@github-actions github-actions bot added the python label Nov 3, 2022
@benfred benfred added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 3, 2022
@benfred benfred self-assigned this Nov 3, 2022
@benfred benfred mentioned this pull request Nov 4, 2022
Open
cjnolet
cjnolet approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benfred these changes look great! Also love knocking out two birds with a single stone.

@cjnolet
Copy link
Member

cjnolet commented Nov 7, 2022

Cc @betatim

@cjnolet
Copy link
Member

cjnolet commented Nov 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1d78d88 into rapidsai:branch-22.12 Nov 7, 2022
@benfred benfred deleted the autosync_handle branch November 7, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@benfred benfred

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] pylibraft functions should automatically sync the raft handle when it's not passed
2 participants
@benfred @cjnolet