Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] pylibraft functions should automatically sync the raft handle when it's not passed #971

Closed
cjnolet opened this issue Nov 1, 2022 · 0 comments · Fixed by #987
Closed

[FEA] pylibraft functions should automatically sync the raft handle when it's not passed #971

cjnolet opened this issue Nov 1, 2022 · 0 comments · Fixed by #987
Assignees
@benfred
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Nov 1, 2022

The pylibraft functions all accept an optional raft handle argument. When this is not explicitly passed in, we should synchronize the handle automatically at the end of the function.

The documentation should also be updated for each of the current functions to let the user know each function will create a new handle and synchronize it automatically when not passed in (which may affect performance).
@cjnolet cjnolet added the feature request New feature or request label Nov 1, 2022
@benfred benfred self-assigned this Nov 1, 2022
benfred added a commit to benfred/raft that referenced this issue Nov 3, 2022
@benfred
Automatically sync handle when not passed to pylibraft functions
5950a6d 
Closes rapidsai#971
@benfred benfred mentioned this issue Nov 3, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #987 Nov 7, 2022
rapids-bot bot pushed a commit that referenced this issue Nov 7, 2022
@benfred
Automatically sync handle when not passed to pylibraft functions (#987)
1d78d88 
Closes #971

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
feature request New feature or request
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically sync handle when not passed to pylibraft functions benfred/raft
2 participants
@benfred @cjnolet