fix nans in naive kl divergence kernel introduced by div by 0. #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormula as one used by main kernel
cjnolet
added
improvement
cjnolet
requested changes
Jun 24, 2022
| @@ -450,10 +449,6 @@ class DistanceTest : public ::testing::TestWithParam<DistanceInputs<DataType>> { | |||
| } | |||
| naiveDistance( | |||
| dist_ref.data(), x.data(), y.data(), m, n, k, distanceType, isRowMajor, metric_arg, stream); | |||
| // size_t worksize = raft::distance::getWorkspaceSize<distanceType, DataType, DataType, | |||
There was a problem hiding this comment.
If this is unneeded, can it just be removed?
There was a problem hiding this comment.
this is commented code which I've already removed.
There was a problem hiding this comment.
Got it! Wow, I totally misread the diff.
cjnolet
approved these changes
Jun 24, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- This address issue #716
-- remove redundant commented code as well.